Your Name
5b9dea2118
gates / consistency-and-conventions (push) Successful in 22s
Permanent coverage for the 2026-09-07 share mountpoint UX change
(commit 35eb90a): the REAL ask_mountpoint body is brace-extracted from
each client file (smb + nfs), exercised through the real common.sh +
share-lib.sh helper chain via the deterministic non-TTY stdin path, with
a fake sudo shim (records to SUDO_LOG, honors SUDO_FAIL) so no real
filesystem is touched.
Covers: existing dir used as-is (rc 0, provable NO confirm / NO mkdir
via empty SUDO_LOG) added by 35eb90a; new-dir confirm=y creates via sudo
mkdir; confirm=n and confirm=EOF both fail closed rc 1; existing
non-directory rejected 'not a directory'; relative / trailing-slash /
system paths (/etc, /root, /home/*/.ssh*) and empty-EOF all rc 1 with no
side effects; mkdir failure rc 1. Stdout purity (path only). Static
guards fail if anyone regresses n=new / n|N / ask_new_mountpoint, and
verify the existing-dir [-d] branch precedes confirm/mkdir. Byte-symmetry
guard keeps smb/nfs bodies identical.
117 checks new (18 files / 416 total). Every case can genuinely fail
(negative-control verified by Tester). Hard-skip contract respected: 0
skips — all cases deterministic non-interactively.
Verified: make check OK, make lint 0 FAIL/0 WARN, make test 18 files /
416 checks / 0 fail / 0 skip (~46s), bash -n clean, git diff --check clean.
55 lines
3.0 KiB
Markdown
55 lines
3.0 KiB
Markdown
# tests/ — regression test suite
|
|
|
|
Zero-dependency Bash regression tests for the Linux_post_install repository.
|
|
|
|
## Run
|
|
|
|
```bash
|
|
make test # discover tests/t-*.sh, run everything
|
|
./tests/run-tests.sh # same
|
|
./tests/run-tests.sh t-telegram-auth.sh # run one file
|
|
```
|
|
|
|
Exit code is non-zero if any check failed. The suite is designed to be
|
|
deterministic: tests stub every external dependency they touch (curl, gpg,
|
|
sudo, systemctl, llama-server, nvidia-smi…) and run against sandbox temp
|
|
dirs. No network, no sudo, no system changes.
|
|
|
|
## Adding a test
|
|
|
|
1. Create `tests/t-<what>.sh` with a `run_test()` function. `set -euo pipefail`
|
|
is already active (the runner re-asserts it); `$ROOT` is the repo root,
|
|
`$TEST_TMP` a per-test temp dir that is cleaned automatically.
|
|
2. Use the helpers in `tests/test-lib.sh` for every assertion:
|
|
`check`, `check_eq`, `check_rc`, `check_contains`, `check_not_contains`,
|
|
`check_file_exists`, `check_file_absent`, `test_run` / `test_run_env`,
|
|
`mksandbox`, `tracked_tree_copy`, `count_token`.
|
|
3. If a case cannot run in the current environment (missing binary, missing
|
|
analyzer), call `skip_case "<desc>" "<reason>"` — never fake a pass and
|
|
never silently return.
|
|
4. Keep total suite runtime under 90 seconds.
|
|
|
|
## Skip contract (hard)
|
|
|
|
A test that cannot run must say `[SKIP] reason`. The runner counts skips in
|
|
the summary and a file whose `run_test()` produced zero checks and zero skips
|
|
is reported as FAIL ("no assertions") — a broken harness can never pass
|
|
silently.
|
|
|
|
## Suite contents
|
|
|
|
| File | What it verifies |
|
|
| --- | --- |
|
|
| `t-ai-server-flags.sh` | `pos-ai-server` ExecStart flag set: defaults, CLI, config, dedupe, one-token-per-flag |
|
|
| `t-ai-hf-download.sh` | `pos ai hf download` success + failure honesty (no `.hf-meta` on partial failure, rc != 0) |
|
|
| `t-ai-llama-detect.sh` | `pos ai-server status` version detection, "unknown", missing-binary failure |
|
|
| `t-unsupported-flags.sh` | unsupported-option handling: CLI/config/env hard errors, dropped defaults, word-boundary match |
|
|
| `t-systemd-unit.sh` | generated unit: one ExecStart, quoted paths, `systemd-analyze verify` |
|
|
| `t-telegram-auth.sh` | Telegram listener chat+owner gate and owner-unset fail-closed |
|
|
| `t-matrix-auth.sh` | Matrix listener room+owner gate and room-unset fail-closed |
|
|
| `t-gpg-password.sh` | backup passphrase on fd 3 (never argv), plaintext/corrupt cleanup |
|
|
| `t-config-precedence.sh` | `load_env_file` contract + CLI > env > file > defaults across tools |
|
|
| `t-uninstall-manifest.sh` | install.sh ↔ POS_LIBS symmetry, user-unit discovery, marker-driven plugin removal |
|
|
| `t-gen-docs-drift.sh` | `make gen` idempotence on a pristine tracked tree (CI drift gate) |
|
|
| `t-lint-gate.sh` | `make lint` green on the real tree; planted violations are caught and named |
|
|
| `t-share-mountpoint.sh` | share-client `ask_mountpoint` UX: existing/new/declined/rejected paths, confirm gate, mkdir side effects, non-TTY stdin contract, static `n`→`t` guards | |