Your Name
11b4a679a8
gates / consistency-and-conventions (push) Successful in 20s
bank.env is line-oriented (name|description|command) so commands with real newlines spanned records: bank_load truncated the command to its first line and the remaining script lines became bogus entries. The bank_get+cut -f3 retrieval path also truncated at embedded tabs. - lib/bank-lib.sh: v2 format escapes backslash->\\ and newline->\\n in the command field, writes # BANK_VERSION: 2; bank_load decodes with printf %b only for v2 files, so existing v1 files load raw (backward compatible, verified against the real ts-google entry). - bin/pos-bank: cmd_show/cmd_run/cmd_edit now read fields from the BANK_* arrays via bank_find instead of bank_get+cut. - tests/t-bank.sh: +13 checks (71 total) - multiline round-trip exact bytes, literal backslash-n, v1 raw-backslash compat, v1+re-save byte-identical, CLI show/run full script.
60 lines
4.1 KiB
Markdown
60 lines
4.1 KiB
Markdown
# tests/ — regression test suite
|
|
|
|
Zero-dependency Bash regression tests for the Linux_post_install repository.
|
|
|
|
## Run
|
|
|
|
```bash
|
|
make test # discover tests/t-*.sh, run everything
|
|
./tests/run-tests.sh # same
|
|
./tests/run-tests.sh t-telegram-auth.sh # run one file
|
|
```
|
|
|
|
Exit code is non-zero if any check failed. The suite is designed to be
|
|
deterministic: tests stub every external dependency they touch (curl, gpg,
|
|
sudo, systemctl, llama-server, nvidia-smi…) and run against sandbox temp
|
|
dirs. No network, no sudo, no system changes.
|
|
|
|
## Adding a test
|
|
|
|
1. Create `tests/t-<what>.sh` with a `run_test()` function. `set -euo pipefail`
|
|
is already active (the runner re-asserts it); `$ROOT` is the repo root,
|
|
`$TEST_TMP` a per-test temp dir that is cleaned automatically.
|
|
2. Use the helpers in `tests/test-lib.sh` for every assertion:
|
|
`check`, `check_eq`, `check_rc`, `check_contains`, `check_not_contains`,
|
|
`check_file_exists`, `check_file_absent`, `test_run` / `test_run_env`,
|
|
`mksandbox`, `tracked_tree_copy`, `count_token`.
|
|
3. If a case cannot run in the current environment (missing binary, missing
|
|
analyzer), call `skip_case "<desc>" "<reason>"` — never fake a pass and
|
|
never silently return.
|
|
4. Keep total suite runtime under 90 seconds.
|
|
|
|
## Skip contract (hard)
|
|
|
|
A test that cannot run must say `[SKIP] reason`. The runner counts skips in
|
|
the summary and a file whose `run_test()` produced zero checks and zero skips
|
|
is reported as FAIL ("no assertions") — a broken harness can never pass
|
|
silently.
|
|
|
|
## Suite contents
|
|
|
|
| File | What it verifies |
|
|
| --- | --- |
|
|
| `t-ai-server-flags.sh` | `pos-ai-server` ExecStart flag set: defaults, CLI, config, dedupe, one-token-per-flag |
|
|
| `t-ai-hf-download.sh` | `pos ai hf download` success + failure honesty (no `.hf-meta` on partial failure, rc != 0) |
|
|
| `t-ai-key-resolution.sh` | `pos ai` API-key contract: provider key > legacy `AI_API_KEY` fallback > error; leakage guard, env-wins, providers status sync |
|
|
| `t-ai-llama-detect.sh` | `pos ai-server status` version detection, "unknown", missing-binary failure |
|
|
| `t-unsupported-flags.sh` | unsupported-option handling: CLI/config/env hard errors, dropped defaults, word-boundary match |
|
|
| `t-systemd-unit.sh` | generated unit: one ExecStart, quoted paths, `systemd-analyze verify` |
|
|
| `t-telegram-auth.sh` | Telegram listener chat+owner gate and owner-unset fail-closed |
|
|
| `t-matrix-auth.sh` | Matrix listener room+owner gate and room-unset fail-closed |
|
|
| `t-gpg-password.sh` | backup passphrase on fd 3 (never argv), plaintext/corrupt cleanup |
|
|
| `t-config-precedence.sh` | `load_env_file` contract + CLI > env > file > defaults across tools |
|
|
| `t-uninstall-manifest.sh` | install.sh ↔ POS_LIBS symmetry, user-unit discovery, marker-driven plugin removal |
|
|
| `t-gen-docs-drift.sh` | `make gen` idempotence on a pristine tracked tree (CI drift gate) |
|
|
| `t-lint-gate.sh` | `make lint` green on the real tree; planted violations are caught and named |
|
|
| `t-install-version.sh` | install.sh version gate: match→skip, mismatch→proceed, --force bypass, dry-run variant, flag write, numeric comparison |
|
|
| `t-share-mountpoint.sh` | share-client `ask_mountpoint` UX: existing/new/declined/rejected paths, confirm gate, mkdir side effects, non-TTY stdin contract, static `n`→`t` guards |
|
|
| `t-pos-media-yt.sh` | unified `pos media yt` suite: dispatcher + forwarder resolution, shared yt-lib helpers, yt-mp3/mp4/grab/subtitles flags, dry-run deps, `YT_OUT_DIR` seam, `GRAB_DEFAULT` config, negative controls (unsafe-URL no-expansion, `--lang en,ar` single arg, txt timestamp-stripping) |
|
|
| `t-telegram-listener-singleton.sh` | Telegram listener single-instance guard: first `--run` acquires the flock, second `--run` fails fast with the exact message, lock auto-releases so the next start is clean, `--status` reports the lock state |
|
|
| `t-bank.sh` | Command Bank: bank-lib.sh unit tests (add/remove/update/find/get/list/count/valid/extract_params/substitute_params, multiline `\n` storage round-trip, literal-`\n` escape round-trip, v1 backward compat) + pos-bank CLI integration (help, list, add, show, run, remove, params, invalid name, multiline show/run) | |