Files

T

gates / consistency-and-conventions (push) Successful in 23s

Details

fix: Telegram listener — async command execution + singleton guard

Root cause: run_and_reply() blocked the entire listener synchronously.
FFmpeg hung because child processes inherited stdin (waiting for 'q').
Long-running commands froze the listener for up to 120s.

Fix:
- Commands run in background with stdin=/dev/null, output to temp file
- reap_commands() collects output non-blocking after each getUpdates cycle
- SIGCHLD handler pre-caches exit codes via wait -n
- TERM/INT trap kills background processes and cleans temp files
- Singleton guard (flock) prevents duplicate listeners racing getUpdates

Tests:
- t-telegram-listener-exec.sh: 12 hermetic checks (echo, pipes, stderr,
  compound commands, long-running, quiet mode)
- t-telegram-listener-singleton.sh: 8 checks (lock acquire/release/status)

Architect verdict: accepted as-is, no re-architecture needed.

2026-09-09 17:17:56 -04:00

3.8 KiB

Raw Blame History

tests/ — regression test suite

Zero-dependency Bash regression tests for the Linux_post_install repository.

Run

make test          # discover tests/t-*.sh, run everything
./tests/run-tests.sh                     # same
./tests/run-tests.sh t-telegram-auth.sh  # run one file

Exit code is non-zero if any check failed. The suite is designed to be deterministic: tests stub every external dependency they touch (curl, gpg, sudo, systemctl, llama-server, nvidia-smi…) and run against sandbox temp dirs. No network, no sudo, no system changes.

Adding a test

Create tests/t-<what>.sh with a run_test() function. set -euo pipefail is already active (the runner re-asserts it); $ROOT is the repo root, $TEST_TMP a per-test temp dir that is cleaned automatically.
Use the helpers in tests/test-lib.sh for every assertion: check, check_eq, check_rc, check_contains, check_not_contains, check_file_exists, check_file_absent, test_run / test_run_env, mksandbox, tracked_tree_copy, count_token.
If a case cannot run in the current environment (missing binary, missing analyzer), call skip_case "<desc>" "<reason>" — never fake a pass and never silently return.
Keep total suite runtime under 90 seconds.

Skip contract (hard)

A test that cannot run must say [SKIP] reason. The runner counts skips in the summary and a file whose run_test() produced zero checks and zero skips is reported as FAIL ("no assertions") — a broken harness can never pass silently.

Suite contents

File	What it verifies
`t-ai-server-flags.sh`	`pos-ai-server` ExecStart flag set: defaults, CLI, config, dedupe, one-token-per-flag
`t-ai-hf-download.sh`	`pos ai hf download` success + failure honesty (no `.hf-meta` on partial failure, rc != 0)
`t-ai-key-resolution.sh`	`pos ai` API-key contract: provider key > legacy `AI_API_KEY` fallback > error; leakage guard, env-wins, providers status sync
`t-ai-llama-detect.sh`	`pos ai-server status` version detection, "unknown", missing-binary failure
`t-unsupported-flags.sh`	unsupported-option handling: CLI/config/env hard errors, dropped defaults, word-boundary match
`t-systemd-unit.sh`	generated unit: one ExecStart, quoted paths, `systemd-analyze verify`
`t-telegram-auth.sh`	Telegram listener chat+owner gate and owner-unset fail-closed
`t-matrix-auth.sh`	Matrix listener room+owner gate and room-unset fail-closed
`t-gpg-password.sh`	backup passphrase on fd 3 (never argv), plaintext/corrupt cleanup
`t-config-precedence.sh`	`load_env_file` contract + CLI > env > file > defaults across tools
`t-uninstall-manifest.sh`	install.sh ↔ POS_LIBS symmetry, user-unit discovery, marker-driven plugin removal
`t-gen-docs-drift.sh`	`make gen` idempotence on a pristine tracked tree (CI drift gate)
`t-lint-gate.sh`	`make lint` green on the real tree; planted violations are caught and named
`t-install-version.sh`	install.sh version gate: match→skip, mismatch→proceed, --force bypass, dry-run variant, flag write, numeric comparison
`t-share-mountpoint.sh`	share-client `ask_mountpoint` UX: existing/new/declined/rejected paths, confirm gate, mkdir side effects, non-TTY stdin contract, static `n`→`t` guards
`t-pos-media-yt.sh`	unified `pos media yt` suite: dispatcher + forwarder resolution, shared yt-lib helpers, yt-mp3/mp4/grab/subtitles flags, dry-run deps, `YT_OUT_DIR` seam, `GRAB_DEFAULT` config, negative controls (unsafe-URL no-expansion, `--lang en,ar` single arg, txt timestamp-stripping)
`t-telegram-listener-singleton.sh`	Telegram listener single-instance guard: first `--run` acquires the flock, second `--run` fails fast with the exact message, lock auto-releases so the next start is clean, `--status` reports the lock state

3.8 KiB Raw Blame History

tests/ — regression test suite

Run

Adding a test

Skip contract (hard)

Suite contents

3.8 KiB

Raw Blame History