Files

T

gates / consistency-and-conventions (push) Successful in 33s

Details

feat: install.sh version gate — --force + per-commit 0.0cN

Architect-approved (C): install.sh now skips+aborts (exit 0) when the
installed version equals the current git-derived version, with a --force
flag to re-install. Version scheme 0.0cN (N = git commit count) bumps by
construction on every commit.

- install_version(): derives 0.0c$count via git rev-list; empty when .git
  absent (gate skipped); INSTALL_VERSION_OVERRIDE presence-check seam for
  tests (empty override simulates no-git deterministically)
- Gate after arg parse, before phases; numeric comparison (strip 0.0c, -eq);
  messages: 'Already installed (X). Use --force to re-install.' and
  '(dry-run) Would skip install: already at version X', both exit 0
- flag_set installed_version after 'Bootstrap complete' banner (not in
  dry-run, even under --force, never on phase failure)
- Docs: SCRIPTS.md flag table + gate description, AGENT_Context line count
  248->301 + flags + flow diagram, README --force row, tests/README row,
  AGENT_TODO Done entry

Verified: new tests/t-install-version.sh 21 checks (9 contracted cases,
real install.sh + hermetic env seams); suite 20 files / 461 checks /
0 fail / 0 skip; make gen byte-idempotent; make check OK; make lint
0 FAIL, 0 WARN; bash -n clean; git diff --check clean; Reviewer
APPROVE_WITH_NOTES with 3 mutation disproofs (8/21, 9/21, 4/21 fail)

2026-09-08 10:17:31 -04:00

3.3 KiB

Raw Blame History

tests/ — regression test suite

Zero-dependency Bash regression tests for the Linux_post_install repository.

Run

make test          # discover tests/t-*.sh, run everything
./tests/run-tests.sh                     # same
./tests/run-tests.sh t-telegram-auth.sh  # run one file

Exit code is non-zero if any check failed. The suite is designed to be deterministic: tests stub every external dependency they touch (curl, gpg, sudo, systemctl, llama-server, nvidia-smi…) and run against sandbox temp dirs. No network, no sudo, no system changes.

Adding a test

Create tests/t-<what>.sh with a run_test() function. set -euo pipefail is already active (the runner re-asserts it); $ROOT is the repo root, $TEST_TMP a per-test temp dir that is cleaned automatically.
Use the helpers in tests/test-lib.sh for every assertion: check, check_eq, check_rc, check_contains, check_not_contains, check_file_exists, check_file_absent, test_run / test_run_env, mksandbox, tracked_tree_copy, count_token.
If a case cannot run in the current environment (missing binary, missing analyzer), call skip_case "<desc>" "<reason>" — never fake a pass and never silently return.
Keep total suite runtime under 90 seconds.

Skip contract (hard)

A test that cannot run must say [SKIP] reason. The runner counts skips in the summary and a file whose run_test() produced zero checks and zero skips is reported as FAIL ("no assertions") — a broken harness can never pass silently.

Suite contents

File	What it verifies
`t-ai-server-flags.sh`	`pos-ai-server` ExecStart flag set: defaults, CLI, config, dedupe, one-token-per-flag
`t-ai-hf-download.sh`	`pos ai hf download` success + failure honesty (no `.hf-meta` on partial failure, rc != 0)
`t-ai-key-resolution.sh`	`pos ai` API-key contract: provider key > legacy `AI_API_KEY` fallback > error; leakage guard, env-wins, providers status sync
`t-ai-llama-detect.sh`	`pos ai-server status` version detection, "unknown", missing-binary failure
`t-unsupported-flags.sh`	unsupported-option handling: CLI/config/env hard errors, dropped defaults, word-boundary match
`t-systemd-unit.sh`	generated unit: one ExecStart, quoted paths, `systemd-analyze verify`
`t-telegram-auth.sh`	Telegram listener chat+owner gate and owner-unset fail-closed
`t-matrix-auth.sh`	Matrix listener room+owner gate and room-unset fail-closed
`t-gpg-password.sh`	backup passphrase on fd 3 (never argv), plaintext/corrupt cleanup
`t-config-precedence.sh`	`load_env_file` contract + CLI > env > file > defaults across tools
`t-uninstall-manifest.sh`	install.sh ↔ POS_LIBS symmetry, user-unit discovery, marker-driven plugin removal
`t-gen-docs-drift.sh`	`make gen` idempotence on a pristine tracked tree (CI drift gate)
`t-lint-gate.sh`	`make lint` green on the real tree; planted violations are caught and named
`t-install-version.sh`	install.sh version gate: match→skip, mismatch→proceed, --force bypass, dry-run variant, flag write, numeric comparison
`t-share-mountpoint.sh`	share-client `ask_mountpoint` UX: existing/new/declined/rejected paths, confirm gate, mkdir side effects, non-TTY stdin contract, static `n`→`t` guards

3.3 KiB Raw Blame History

tests/ — regression test suite

Run

Adding a test

Skip contract (hard)

Suite contents

3.3 KiB

Raw Blame History