Your Name
8ce54794ee
gates / consistency-and-conventions (push) Successful in 27s
User report: pressing Enter on 'System prompt (empty = use built-in)' silently returned to the menu — no alias created, and step labels read [1/4] [2/4] in a 5-step flow. Detective (pre-existing, not a 2026-09-06 regression): menu_ask_value's documented contract is 'rc 1 = cancel, or empty answer with no default'; the step-4 call passed an empty default so the advertised empty answer hit rc 1 and '|| return 0' aborted the flow. Same latent trap at the alias-name step (empty-name warn/re-prompt was dead code). 11 other call sites are correct (6 external rely on empty=cancel, 4 pass defaults) — no global semantic change allowed. Architect: opt-in --allow-empty flag on menu_ask_value (backward compatible; empty+no-default -> rc 0 + empty value; genuine cancel/EOF stays rc 1; default still wins). Builder: implemented in lib/menu-lib.sh + bin/pos-ai-alias (steps 1-2 relabeled /5, flag at the two approved sites); 7-case smoke matrix PASS. Tests: tests/t-menu-allow-empty.sh (30 checks) — semantics matrix against the real menu_ask_value via non-TTY stdin, reader-contract probes (empty-Enter rc 0 vs EOF rc 1), static guards on step labeling, the exactly-2 flag call sites, edit-flow untouched, and a scope fence over all pos-* tools. Pty E2E proven feasible (script -qec, 3 scenarios) and documented in the Tester report; the E2E file itself remains a follow-up. Verified: make gen idempotent; make check OK; make lint 0 FAIL, 0 WARN; make test 17 files / 299 checks / 0 fail / 0 skip (~49s); bash -n clean.
tests/ — regression test suite
Zero-dependency Bash regression tests for the Linux_post_install repository.
Run
make test # discover tests/t-*.sh, run everything
./tests/run-tests.sh # same
./tests/run-tests.sh t-telegram-auth.sh # run one file
Exit code is non-zero if any check failed. The suite is designed to be deterministic: tests stub every external dependency they touch (curl, gpg, sudo, systemctl, llama-server, nvidia-smi…) and run against sandbox temp dirs. No network, no sudo, no system changes.
Adding a test
- Create
tests/t-<what>.shwith arun_test()function.set -euo pipefailis already active (the runner re-asserts it);$ROOTis the repo root,$TEST_TMPa per-test temp dir that is cleaned automatically. - Use the helpers in
tests/test-lib.shfor every assertion:check,check_eq,check_rc,check_contains,check_not_contains,check_file_exists,check_file_absent,test_run/test_run_env,mksandbox,tracked_tree_copy,count_token. - If a case cannot run in the current environment (missing binary, missing
analyzer), call
skip_case "<desc>" "<reason>"— never fake a pass and never silently return. - Keep total suite runtime under 90 seconds.
Skip contract (hard)
A test that cannot run must say [SKIP] reason. The runner counts skips in
the summary and a file whose run_test() produced zero checks and zero skips
is reported as FAIL ("no assertions") — a broken harness can never pass
silently.
Suite contents
| File | What it verifies |
|---|---|
t-ai-server-flags.sh |
pos-ai-server ExecStart flag set: defaults, CLI, config, dedupe, one-token-per-flag |
t-ai-hf-download.sh |
pos ai hf download success + failure honesty (no .hf-meta on partial failure, rc != 0) |
t-ai-llama-detect.sh |
pos ai-server status version detection, "unknown", missing-binary failure |
t-unsupported-flags.sh |
unsupported-option handling: CLI/config/env hard errors, dropped defaults, word-boundary match |
t-systemd-unit.sh |
generated unit: one ExecStart, quoted paths, systemd-analyze verify |
t-telegram-auth.sh |
Telegram listener chat+owner gate and owner-unset fail-closed |
t-matrix-auth.sh |
Matrix listener room+owner gate and room-unset fail-closed |
t-gpg-password.sh |
backup passphrase on fd 3 (never argv), plaintext/corrupt cleanup |
t-config-precedence.sh |
load_env_file contract + CLI > env > file > defaults across tools |
t-uninstall-manifest.sh |
install.sh ↔ POS_LIBS symmetry, user-unit discovery, marker-driven plugin removal |
t-gen-docs-drift.sh |
make gen idempotence on a pristine tracked tree (CI drift gate) |
t-lint-gate.sh |
make lint green on the real tree; planted violations are caught and named |