2 Commits

Author	SHA1	Message	Date
Your Name	0b5043a9f3	fix: llama-server start breakage — version detection, flag-validation race, model dir resolution, user-bus pre-flight ... User report after the llamacpp app install: 'installed llama.cpp unknown', valid flags rejected (randomly per run), 'Model not found' for the HF downloader's own layout, and a systemd user-bus failure over SSH. Detective (real b10822 binary, FACT) found four independent causes: - version: llama-server --version prints to STDERR; detect_llama_version's 2>/dev/null swallowed it -> always 'unknown'. Now captures 2>&1 + accepts semver/build tokens (incl. build 1.2.3 edge) - validation: printf|grep -q under pipefail -> SIGPIPE rc=141 race randomly rejected flags present in the 59 KB --help. Now pipe-less grep (no race); 20x determinism regression test - model resolution: resolve_model accepted files only, but the HF downloader creates <models>/<repo>/file.gguf dirs. Now expands a dir with exactly one *.gguf (never silently picks; multi-gguf lists + errs) - port: llama.cpp default 8080 vs tool/adapter 8088; validation reliability means --port is now always pinned in the unit - user bus: headless/SSH sessions lack XDG_RUNTIME_DIR -> ensure_user_bus in lib/common.sh pre-flights all three systemctl --user tools with remediation text; pos ai server --no-unit direct-run escape hatch (pidfile) for boxes with no bus - find_llamacpp narrowed to llama-server/llama-server-cuda (bare 'server' fallback hazard); installer post-install sanity (version+help execute, symlink targets resolve) Architect decisions DQ1-DQ6 recorded. Tester: 4 new regression files (version-from-stderr, 25x flag-validation determinism, model dir expansion, bus pre-flight + E2E) + 3 fixture updates; suite 16 files / 269 checks. Verified: make gen idempotent; make check OK; make lint 0 FAIL, 0 WARN; make test 269/269 (~49s); bash -n clean; git diff --check clean.	2026-09-06 09:25:52 -04:00
Your Name	d817c37652	fix: stabilization pass — fail-closed auth, ai flag validation, lint/config/security hardening, regression tests ... 17-point code-level audit executed via Explorer->Architect->Builder->Tester->Reviewer; Reviewer accepted (APPROVE_WITH_NOTES; 3 block-list items resolved): - security: telegram sender-owner AND-gate + TELEGRAM_OWNER_ID, matrix MATRIX_ROOM_ID fail-closed, gpg --passphrase-fd 3 (no argv secret), /dev/tcp positional-arg form (checkport/smb-client/share-lib/NET_PROBE), eval deny-by-default + --no-command-execution carried by both chat bridges, tty-gated --trust; config/{telegram,matrix}.env reference templates - ai: all ExecStart flags validated against installed llama.cpp (requested->error, default->omit+warn, CONFIG_REQUESTED_FLAGS); single-file hf download failure rc=1 + no .hf-meta; LLAMACPP_HOST coherent; POS_SUBCMDS + metadata gaps closed - tooling: lint-conventions Bash-native rewrite (~24-30x faster, rules and output byte-identical, :num restored); pos system uninstall covers all 12 libs + scale-tail + flags dir + systemd user units (|| true) + plugin markers; anchored .bash_completion/.bashrc removal replaces sed -i '/pos/d' - config: canonical load_env_file in lib/config-ui.sh (CRLF strip, env-wins, XDG, LOADED_ENV_KEYS); 9 tools migrated; entertainment-lib collapsed to wrappers; docker-compose deliberately unmigrated (source semantics) - tests: first committed regression suite — tests/run-tests.sh zero-dep runner + make test; 12 files / 179 checks / 0 skip / ~52s; hard skip contract; systemd-analyze verify on generated unit PASS Verified: make gen idempotent; make check green; make lint 0 FAIL, 0 WARN; make test green; bash -n clean; git diff --check clean. Audit deliverables + agent reports + AGENT_TODO Done entry included.	2026-09-06 07:25:44 -04:00