From 73d15a26b4a4c38080ed7b44bf66030cf63c8cb8 Mon Sep 17 00:00:00 2001
From: Your Name <you@example.com>
Date: Sat, 12 Sep 2026 03:28:15 -0400
Subject: [PATCH] fix: register bank-lib.sh (and yt-lib.sh) in
 install/uninstall lib manifests

lib/bank-lib.sh was added for pos bank but never registered in install.sh's
phase-2 lib copy list, so it never reached /usr/local/bin and pos bank failed
after install. Also restored yt-lib.sh to POS_LIBS (pre-existing gap: uninstall
left it behind). Symmetry gate tests/t-uninstall-manifest.sh now passes.
---
 DOC/AGENT_Context_Project.md                  |  9 ++++----
 DOC/SCRIPTS.md                                |  2 +-
 bin/pos-system-uninstall                      |  3 ++-
 install.sh                                    |  2 +-
 .../maintainer-decision-lib-registration.md   | 22 +++++++++++++++++++
 5 files changed, 31 insertions(+), 7 deletions(-)
 create mode 100644 memory/decisions/maintainer-decision-lib-registration.md

diff --git a/DOC/AGENT_Context_Project.md b/DOC/AGENT_Context_Project.md
index 5a55347..9d698b6 100644
--- a/DOC/AGENT_Context_Project.md
+++ b/DOC/AGENT_Context_Project.md
@@ -21,8 +21,8 @@
 | ## 10. Configuration Files | 499–525 |
 | ## 11. Coding Conventions | 526–558 |
 | ## 12. Development Workflow | 559–611 |
-| ## 13. Key File Quick Reference | 612–696 |
-| ## 14. Common Tasks for Agents | 697–730 |
+| ## 13. Key File Quick Reference | 612–697 |
+| ## 14. Common Tasks for Agents | 698–731 |
 <!-- GEN:END docmap -->
 
 ## 1. Project Overview
@@ -232,7 +232,7 @@ User runs: ./install.sh [--apps|--full|--feature|--dry-run|--force|--skip <phase
 │   └─ Copies bin/* → /usr/local/bin/ (chmod 755)
 │   └─ Copies lib/*.sh (common, flags, notify, registry, entertainment-lib,
 │      scheduler-lib, config-ui, user-timers-lib, entertainment-plugin-lib,
-│      usb-lib, share-lib, menu-lib, yt-lib) → /usr/local/bin/ (chmod 644)
+│      usb-lib, share-lib, menu-lib, yt-lib, bank-lib) → /usr/local/bin/ (chmod 644)
 │   └─ Copies x64_bin/* → /usr/local/bin/ on x86_64 (arm64_bin/ on aarch64)
 │   └─ [if --feature] Copies features/* → /usr/local/bin/ (asks before overwriting),
 │                      then sets the matching feature flag
@@ -628,6 +628,7 @@ Use conventional prefixes: `feat:`, `fix:`, `docs:`, `refactor:`, `chore:`
 | `lib/menu-lib.sh` | 362 | Category-neutral interactive menu primitives (`menu_guard` tty guard, `menu_run` looping boxed menu, `menu_pick` type-to-filter picker, `menu_ask_value` prompt-with-default via raw-mode bracketed-paste-safe `menu_read_value`; stderr render, fail-closed on non-tty/EOF) — sourced by `share-lib.sh`, open to any category |
 | `lib/registry.sh` | 199 | Shared query API for POS tool metadata headers (`# POS_*:`) — `reg_scan`/`reg_list`/`reg_lookup`/`reg_each`/config scope helpers; used by `pos-tree` and `gen-docs.sh` |
 | `lib/yt-lib.sh` | 50 | Shared YouTube helpers for `pos media yt *` (`yt_check_deps`, `yt_validate_url`, `yt_echo_cmd`, `classify_url`) — sourced by `yt-mp3`/`yt-mp4`/`yt-grab`/`yt-subtitles` |
+| `lib/bank-lib.sh` | 175 | Shared Command Bank storage helpers for `pos bank` (`bank_load`/`bank_save`/`bank_add`/`bank_remove`/`bank_update`, `{param}` template substitution; store `~/.config/linux_post_install/bank.env`) — sourced by `pos-bank` |
 | `bin/flag-reader` | 58 | Inspect flags (list/status/`--raw`) |
 | `bin/flag-set` | 21 | Set a flag (optionally with a value) |
 | `bin/flag-clear` | 21 | Unset a flag |
@@ -683,7 +684,7 @@ Use conventional prefixes: `feat:`, `fix:`, `docs:`, `refactor:`, `chore:`
 | `bin/pos-system-firewall` | 325 | Interactive UFW management |
 | `bin/pos-system-health` | 209 | Host health dashboard (disk, RAM, services, backup age, fail2ban, docker); exit 1 if any FAIL |
 | `bin/pos-system-schedule` | 151 | Scheduled jobs: run a command on a timer; notify on threshold/change/error/always or silently |
-| `bin/pos-system-uninstall` | 517 | Remove pos toolkit binaries, services, shell integration, config, and data |
+| `bin/pos-system-uninstall` | 518 | Remove pos toolkit binaries, services, shell integration, config, and data |
 | `bin/pos-ai` | 714 | AI assistant: ask, chat, sessions, capture, models, providers |
 | `bin/pos-bank` | 313 | Persistent command bank for saving and running shell commands |
 | `bin/pos-config` | 80 | Interactive editor for the tools' runtime config (reads # POS_CONFIG: registry) |
diff --git a/DOC/SCRIPTS.md b/DOC/SCRIPTS.md
index ca019d7..bd6ecb0 100644
--- a/DOC/SCRIPTS.md
+++ b/DOC/SCRIPTS.md
@@ -45,7 +45,7 @@ The phases:
 | # | Phase | Script/action |
 |---|-------|----------------|
 | 1 | preinstall | `preinstall.sh` — apt packages + yt-dlp |
-| 2 | scripts | Copies `bin/*` → `/usr/local/bin/` (755), `lib/common.sh` + `lib/flags.sh` + `lib/notify.sh` + `lib/entertainment-lib.sh` + `lib/entertainment-plugin-lib.sh` + `lib/scheduler-lib.sh` + `lib/config-ui.sh` + `lib/user-timers-lib.sh` + `lib/usb-lib.sh` + `lib/share-lib.sh` + `lib/menu-lib.sh` + `lib/registry.sh` + `lib/yt-lib.sh` → `/usr/local/bin/` (644). Copies precompiled arch binaries from `x64_bin/` (or `arm64_bin/`) → `/usr/local/bin/`. With `--feature`: also installs `features/*` (see below) |
+| 2 | scripts | Copies `bin/*` → `/usr/local/bin/` (755), `lib/common.sh` + `lib/flags.sh` + `lib/notify.sh` + `lib/entertainment-lib.sh` + `lib/entertainment-plugin-lib.sh` + `lib/scheduler-lib.sh` + `lib/config-ui.sh` + `lib/user-timers-lib.sh` + `lib/usb-lib.sh` + `lib/share-lib.sh` + `lib/menu-lib.sh` + `lib/registry.sh` + `lib/yt-lib.sh` + `lib/bank-lib.sh` → `/usr/local/bin/` (644). Copies precompiled arch binaries from `x64_bin/` (or `arm64_bin/`) → `/usr/local/bin/`. With `--feature`: also installs `features/*` (see below) |
 | 3 | postinstall | `postinstall.sh` — PATH, completion, SSH keys, systemd |
 | 4 | scalepoint | Shallow-clones ScaleTail templates to `/usr/local/share/linux_post_install/scale-tail` |
 | 5 (opt) | apps | `apps/install.sh` when `--apps` (interactive) or `--full` (all, non-interactive) |
diff --git a/bin/pos-system-uninstall b/bin/pos-system-uninstall
index dc46a9d..c7ced22 100755
--- a/bin/pos-system-uninstall
+++ b/bin/pos-system-uninstall
@@ -55,7 +55,8 @@ done
 # ── pos-owned installed files (single source of truth, mirrors install.sh) ──
 # lib/*.sh list shipped by install.sh phase 2 to /usr/local/bin.
 POS_LIBS=(common.sh flags.sh notify.sh entertainment-lib.sh scheduler-lib.sh config-ui.sh \
-    user-timers-lib.sh entertainment-plugin-lib.sh usb-lib.sh share-lib.sh menu-lib.sh registry.sh)
+    user-timers-lib.sh entertainment-plugin-lib.sh usb-lib.sh share-lib.sh menu-lib.sh registry.sh \
+    yt-lib.sh bank-lib.sh)
 # Exact lines postinstall.sh appends to ~/.bashrc.
 PATH_LINE='export PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:$HOME/.local/bin:$PATH"'
 COMPLETION_LINE='source /usr/local/share/bash-completion/completions/pos.bash 2>/dev/null || true'
diff --git a/install.sh b/install.sh
index 92825c3..469b6b6 100755
--- a/install.sh
+++ b/install.sh
@@ -175,7 +175,7 @@ if should_run 2 scripts; then
     done
     lib_count=0
     lib_names=""
-    for lf in common.sh flags.sh notify.sh entertainment-lib.sh scheduler-lib.sh config-ui.sh user-timers-lib.sh entertainment-plugin-lib.sh usb-lib.sh share-lib.sh menu-lib.sh registry.sh yt-lib.sh; do
+    for lf in common.sh flags.sh notify.sh entertainment-lib.sh scheduler-lib.sh config-ui.sh user-timers-lib.sh entertainment-plugin-lib.sh usb-lib.sh share-lib.sh menu-lib.sh registry.sh yt-lib.sh bank-lib.sh; do
         run sudo install -m 644 "lib/$lf" "/usr/local/bin/$lf"
         lib_count=$((lib_count + 1))
         lib_names+="$lf "
diff --git a/memory/decisions/maintainer-decision-lib-registration.md b/memory/decisions/maintainer-decision-lib-registration.md
new file mode 100644
index 0000000..b6c99b5
--- /dev/null
+++ b/memory/decisions/maintainer-decision-lib-registration.md
@@ -0,0 +1,22 @@
+# Decision: lib-registration standard is a 3-surface symmetry (install.sh + POS_LIBS + docs)
+
+## Finding (2026-09-12, MAINTENANCE_COMPLETE)
+
+lib/bank-lib.sh (added 41efc91 feat: pos bank) was never registered in install.sh's
+phase-2 lib copy list, bin/pos-system-uninstall's POS_LIBS, or the hand-maintained docs.
+lib/yt-lib.sh had been added to install.sh (0b76d4d) but missed POS_LIBS. Result: after
+`./install.sh`, `pos bank` failed with `/usr/local/bin/bank-lib.sh: No such file or directory`,
+and uninstall would leave stale yt-lib.sh. The symmetry gate tests/t-uninstall-manifest.sh
+(set-equality of the two lists) was failing.
+
+## Established standard (restored)
+
+Every lib/ file sourced by a bin/ tool MUST be registered in all THREE places:
+1. install.sh phase-2 lib copy loop (`for lf in …; do`) → ships to /usr/local/bin,
+2. bin/pos-system-uninstall `POS_LIBS` array (same set, backslash-continuation style),
+3. hand-maintained docs: DOC/SCRIPTS.md phase-2 table row + DOC/AGENT_Context_Project.md
+   phase-2 lib list AND its hand-maintained filetable row (above GEN:START filetable,
+   with real `wc -l` count).
+
+Validator: tests/t-uninstall-manifest.sh (must stay green; it enforces set equality and
+that every listed lib exists). Never edit GEN:START/GEN:END blocks by hand — run make gen.
\ No newline at end of file